Skip to content

feat(dsh): add configured asset inventory - #102

Merged
phodal merged 4 commits into
QoderAI:mainfrom
Cobb04:feat/dsh-configured-assets
Aug 24, 2026
Merged

feat(dsh): add configured asset inventory#102
phodal merged 4 commits into
QoderAI:mainfrom
Cobb04:feat/dsh-configured-assets

Conversation

@Cobb04

@Cobb04 Cobb04 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds the first bounded DeepSeek Harness AGENT_CUSTOMIZE configured-assets slice for effective filesystem Skills and cwd-sensitive Instructions. It follows qualified native DSH precedence and ordering, reports configured-not-observed evidence rather than runtime use, and includes credential-free native verification.

Why

Traceability and Scope

  • Spec/ADR, if applicable: docs/specs/2026-08-23-101-deepseek-harness-configured-assets.md
  • Acceptance criteria addressed: canonical DSH provider and capability registration; native Skill discovery, validation, precedence, and shadowing; cwd-sensitive Instruction ordering, deduplication, source limits, and rendered-byte budgeting; default-closed user-home authorization; bounded diagnostics and minimal CLI; pinned credential-free native comparison.
  • Canonical owners changed: DSH agent-customize provider, registry, capability, and CLI; direct YAML dependency and Antigravity, host-artifact, and standalone runtime-ZIP closures; DSH native smoke and focused tests; configured-assets spec, reference, installation guide, and adapter matrices.
  • Explicit non-goals: runtime/scoped Skill enumeration; full Cordis, Profile, or Preset resolution; MCP, Plugin, or Profile inventory; ASSET_PRACTICES; session-analysis changes; evidence-bundle, report, rendering, or output routing; Quickstart; and claims that configured assets were used at runtime.

Change Type

  • Feature
  • Bug fix
  • Tests only
  • Documentation/community
  • Refactor with no intended behavior change
  • Dependency, packaging, or infrastructure

Test and Review Evidence

Check Result
Focused #101 suites PASS — 79/79
DSH configured-assets native smoke PASS — native DSH and Better Harness comparison phases; no credentials
Existing #99 DSH native smoke PASS — pinned DSH 0.1.1-rc.2 discovery/invocation contract
DSH session regression PASS — 87/87
Documentation link graph PASS — 8/8
Antigravity and host artifact suites PASS — 45 passed, 1 skipped
Clean-source host/runtime packaging PASS — YAML package, runtime files, and license verified without generated-doc exclusions
npm run check PASS
Root Vitest PASS — 1,498 passed, 1 skipped
Harness PASS — 161/161
Harness UI PASS — 29/29
Harness Studio PASS — 205/205
npm run pack:verify PASS — npm 575 entries; runtime ZIP 837 entries
npm audit --omit=dev PASS — 0 vulnerabilities

Manual or visual evidence: This is a non-visual configured-assets and runtime-packaging change. The credential-free native smoke compared filesystem Skill winners, Instruction order and deduplication, byte limits, budgeting, authorization, UTF-8 behavior, and supported symlink cases with pinned DSH owners. Clean-source host and standalone runtime artifacts loaded agent-customize without ERR_MODULE_NOT_FOUND.

Risk and Recovery

  • Compatibility and cross-platform impact: macOS was fully exercised locally. Portable path tests and native fixtures cover Linux/Windows semantics; authoritative Linux and Windows execution remains pending the GitHub Actions matrix.
  • Package, plugin, schema, or generated-file impact: adds exact production yaml@2.9.0 and closes Antigravity, host-artifact, and standalone runtime-ZIP dependency/license boundaries. No shared agent-customize schema or generated-state host packaging policy changes.
  • Rollback or recovery path: revert this commit/PR to remove DSH AGENT_CUSTOMIZE support and its YAML dependency closures; no data migration or cleanup is required.
  • Residual risk or unverified boundary: remote Linux/Windows CI is pending. Behavior is qualified to DSH 0.1.1-rc.2; later DSH releases require explicit requalification.

AI Involvement

  • Level: Assisted
  • Human review and validation: AI assisted repository and upstream-source research, specification drafting, test planning, implementation, review, and packaging diagnosis. Cobb04 reviewed scope alignment, RED-to-GREEN evidence, native parity, packaging causality, the final diff, and full validation, and remains the author and submitter.

Checklist

  • I followed AGENTS.md, CONTRIBUTING.md, and the relevant canonical-owner guidance.
  • The change is focused and does not include unrelated local or generated state.
  • Tests and documentation match the behavior actually delivered.
  • Markdown links were checked when documentation moved or changed.
  • Cross-platform behavior was considered for Windows, macOS, and Linux.
  • Package/runtime verification was run when shipped files or dependencies changed.
  • User-facing or compatibility changes are recorded in CHANGELOG.md.
    Not applicable for [Feature]: Add DeepSeek Harness configured-asset inventory for Skills and Instructions #101: AGENTS.md permits CHANGELOG changes only when explicitly required, and the approved Story/spec does not authorize one; canonical adapter and installation documentation are updated instead.
  • I have the right to contribute this work under the repository's MIT License.

Cobb04 and others added 2 commits August 23, 2026 22:06
@Cobb04 @codex
feat(dsh): add configured asset inventory
178baf9 
Add qualified filesystem Skill winners and cwd-sensitive Instruction sources under a configured-not-observed evidence boundary.

Implements QoderAI#101 using docs/specs/2026-08-23-101-deepseek-harness-configured-assets.md. Validated with credential-free native DSH comparison, focused suites, packaging verification, and npm run check.

Co-authored-by: Codex (GPT 5.6 Sol) <codex@openai.com>
@Cobb04 @codex
test(dsh): fix Node 22 module mock compatibility
7ee924b 
Co-authored-by: Codex (GPT 5.6 Sol) <codex@openai.com>
phodal
phodal requested changes Aug 23, 2026
View reviewed changes

@phodal phodal left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found two native DSH parity issues that need to be fixed. Both were reproduced against exact head 7ee924beda2c: raw Instruction byte-budget semantics and native DSH home normalization. Existing CI, the current-base merge tree, and the regular test suites are green, but these boundary cases are not covered. After fixing them and adding regression coverage, please also update the spec from Status: Draft to reflect the implemented state.

Comment thread scripts/agent-customize/providers/dsh.mjs Outdated
Comment thread scripts/agent-customize/providers/dsh.mjs Outdated
Cobb04 and others added 2 commits August 24, 2026 00:15
@Cobb04 @codex
fix(dsh): align configured assets with native parity
ff0fc86 
Align raw Instruction render-budget accounting and DSH home normalization with qualified DSH 0.1.1-rc.2.

Addresses maintainer review for Story QoderAI#101 using docs/specs/2026-08-23-101-deepseek-harness-configured-assets.md. The change was validated with Node 22.20 and Node 24 focused suites, both pinned native DSH smokes, and the full repository validation sequence with an extended local Vitest timeout for the isolated artifact test.

Co-authored-by: Codex (GPT 5.6 Sol) <codex@openai.com>
@Cobb04 @codex
test(dsh): handle Windows cwd path aliases
fc3e983 
Compare explicit-blank DSH home resolution with the spawned process's own cwd so equivalent Windows 8.3 and long-name path spellings do not create a false failure.

Addresses the Windows CI portability receipt for Story QoderAI#101 using docs/specs/2026-08-23-101-deepseek-harness-configured-assets.md. Validated with the full DSH configured-assets suite on Node 22.20 and Node 24 plus the pinned native smoke.

Co-authored-by: Codex (GPT 5.6 Sol) <codex@openai.com>
@Cobb04
Cobb04 requested a review from phodal August 23, 2026 16:35
phodal
phodal approved these changes Aug 24, 2026
View reviewed changes

@phodal phodal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed exact head fc3e983e00e6. Both requested native DSH parity fixes are complete: raw Instruction content now drives render-budget accounting while trimming is limited to deduplication, and DSH home normalization matches the qualified native implementation for blank environment values and both tilde forms. The regression fixtures, pinned native comparison, current-base merge tree, full local validation, and Linux/macOS/Windows CI are green. No remaining findings.

@phodal
phodal merged commit fabfc7e into QoderAI:main Aug 24, 2026
4 checks passed
@Cobb04 Cobb04 mentioned this pull request Aug 24, 2026
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phodal phodal phodal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Cobb04 @phodal